PR Review requested changes

This commit is contained in:
Dax T. Games 2023-09-26 11:17:16 -04:00
parent 01da2fe638
commit ddad83c70f
2 changed files with 9 additions and 3 deletions

View File

@ -566,7 +566,13 @@ void StartCmder(std::wstring path = L"", bool is_single_mode = false, std::wstr
#endif #endif
PROCESS_INFORMATION pi; PROCESS_INFORMATION pi;
if (!CreateProcess(terminalPath, args, NULL, NULL, false, 0, NULL, NULL, &si, &pi)) { if (!CreateProcess(terminalPath, args, NULL, NULL, false, 0, NULL, NULL, &si, &pi)) {
MessageBox(NULL, _T("Unable to create the terminal process!"), _T("Error"), MB_OK); if (PathFileExists(windowsTerminalDir)) {
MessageBox(NULL, _T("Unable to create the Windows Terminal process!"), _T("Error"), MB_OK);
}
else
{
MessageBox(NULL, _T("Unable to create the ConEmu process!"), _T("Error"), MB_OK);
}
return; return;
} }

View File

@ -77,7 +77,7 @@
"guid": "{eb1f6578-ce9d-47a9-a8c7-9b3fdd22302d}", "guid": "{eb1f6578-ce9d-47a9-a8c7-9b3fdd22302d}",
"hidden": false, "hidden": false,
"icon": "%CMDER_ROOT%\\icons\\cmder_orange.ico", "icon": "%CMDER_ROOT%\\icons\\cmder_orange.ico",
"name": "Cmder - Powershell", "name": "Cmder - PowerShell",
"startingDirectory": "", "startingDirectory": "",
"tabTitle": "Cmder", "tabTitle": "Cmder",
"useAtlasEngine": false "useAtlasEngine": false
@ -89,7 +89,7 @@
"guid": "{c5225c3e-8619-4145-8182-2800814eeb17}", "guid": "{c5225c3e-8619-4145-8182-2800814eeb17}",
"hidden": false, "hidden": false,
"icon": "%CMDER_ROOT%\\icons\\cmder_purple.ico", "icon": "%CMDER_ROOT%\\icons\\cmder_purple.ico",
"name": "Cmder - Powershell as Admin", "name": "Cmder - PowerShell as Admin",
"startingDirectory": "", "startingDirectory": "",
"tabTitle": "Cmder - PowerShell as Admin", "tabTitle": "Cmder - PowerShell as Admin",
"useAtlasEngine": false "useAtlasEngine": false