yanyu/v2board
1
0
Fork 0
mirror of https://github.com/v2board/v2board.git synced 2024-11-10 09:39:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

[security] Fix user info leak in getSubscribe()

Browse Source 
getSubscribe() leaks all user info even password hash, fix it.
This commit is contained in:
Julian Liu 2020-12-31 08:23:46 +08:00 committed by GitHub
parent 4958c94bf2
commit dd51daf9d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/Http/Controllers/User/UserController.php
View File

@ -27,6 +27,9 @@ class UserController extends Controller
public function changePassword(UserChangePassword $request)
{
$user = User::find($request->session()->get('id'));
if (!$user) {
abort(500, '该用户不存在');
}
if (!Helper::multiPasswordVerify(
$user->password_algo,
$request->input('old_password'),
@ -65,6 +68,9 @@ class UserController extends Controller
'telegram_id'
])
->first();
if (!$user) {
abort(500, '该用户不存在');
}
$user['avatar_url'] = 'https://cdn.v2ex.com/gravatar/' . md5($user->email) . '?s=64&d=identicon';
return response([
'data' => $user
@ -90,7 +96,20 @@ class UserController extends Controller
public function getSubscribe(Request $request)
{
$user = User::find($request->session()->get('id'));
$user = User::where('id', $request->session()->get('id'))
->select([
'id',
'plan_id',
'token',
'expired_at',
'u',
'd',
'transfer_enable'
])
->first();
if (!$user) {
abort(500, '该用户不存在');
}
if ($user->plan_id) {
$user['plan'] = Plan::find($user->plan_id);
if (!$user['plan']) {
@ -107,6 +126,9 @@ class UserController extends Controller
public function resetSecurity(Request $request)
{
$user = User::find($request->session()->get('id'));
if (!$user) {
abort(500, '该用户不存在');
}
$user->uuid = Helper::guid(true);
$user->token = Helper::guid();
if (!$user->save()) {